fix(merkle): broken error handling in ValueOp (VSA-2022-100)#601
Merged
fix(merkle): broken error handling in ValueOp (VSA-2022-100)#601
Conversation
lklimek
added a commit
to lklimek/tendermint
that referenced
this pull request
Mar 9, 2023
This is a security fix of https://blog.verichains.io/p/vsa-2022-100-tendermint-forging-membership-proof , backported from dashpay/tenderdash#601
lklimek
added a commit
to lklimek/tendermint
that referenced
this pull request
Mar 9, 2023
This is a security fix of https://blog.verichains.io/p/vsa-2022-100-tendermint-forging-membership-proof , backported from dashpay/tenderdash#601
shotonoff
pushed a commit
that referenced
this pull request
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Due to incorrect error handling, ValueOp is not correctly validated.
See https://blog.verichains.io/p/vsa-2022-100-tendermint-forging-membership-proof for details.
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only