Skip to content

doc: improve protobuf documentation#604

Merged
lklimek merged 3 commits intov0.12-devfrom
doc-protobuf
Mar 17, 2023
Merged

doc: improve protobuf documentation#604
lklimek merged 3 commits intov0.12-devfrom
doc-protobuf

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 14, 2023

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review March 15, 2023 14:47
shotonoff
shotonoff previously approved these changes Mar 15, 2023
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that some parts of the documentation are used Tendermint another one is used Tenderdash,
let's use Tenderdash for consistency

@lklimek lklimek changed the base branch from v0.11-dev to v0.12-dev March 17, 2023 08:25
@lklimek lklimek dismissed shotonoff’s stale review March 17, 2023 08:25

The base branch was changed.

@lklimek lklimek enabled auto-merge (squash) March 17, 2023 08:25
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lklimek lklimek merged commit 969446f into v0.12-dev Mar 17, 2023
@shotonoff shotonoff deleted the doc-protobuf branch March 17, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants