Skip to content

test(types): sign_bytes tests synchronized with rs-tenderdash-abci#623

Merged
lklimek merged 2 commits intov0.12-devfrom
test/sign-bytes
Apr 18, 2023
Merged

test(types): sign_bytes tests synchronized with rs-tenderdash-abci#623
lklimek merged 2 commits intov0.12-devfrom
test/sign-bytes

Conversation

@lklimek
Copy link
Collaborator

@lklimek lklimek commented Apr 14, 2023

Issue being fixed or feature implemented

To test sign_bytes() in rs-tenderdash-abci, we need tests that will use the same data in both projects.

What was done?

  1. Extended TestVoteSignBytes
  2. Implemented TestVoteExtensionsSignBytes
  3. Refactored some tests to make them deterministic (not use random input)
  4. Log some info useful as test vectors

How Has This Been Tested?

Executed the tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review April 17, 2023 15:47
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lklimek lklimek merged commit 55bb222 into v0.12-dev Apr 18, 2023
@lklimek lklimek deleted the test/sign-bytes branch April 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants