refactor(statesync): implement statesync peer manager#648
Merged
refactor(statesync): implement statesync peer manager#648
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Collaborator
|
PR title is confusing, we already have peer manager implemented in p2p |
…ync-peer-manager' into refactor/td-162-implement-statesync-peer-manager
lklimek
reviewed
Jul 25, 2023
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
shotonoff
commented
Jul 26, 2023
Collaborator
Author
shotonoff
left a comment
There was a problem hiding this comment.
PR is ready to new round review
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
lklimek
previously approved these changes
Aug 14, 2023
lklimek
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This is PR is related to the task TD-162:
Each module that communicates with p2p peers has its own simple peer manager implementation. Usually the code is placed into a reactor. As a result of the refactoring, peer management has been moved out of the reactor and into a separate component.
The component must listen to peer
upanddownevents and register the peer into the peer store or remove it.What was done?
statesyncchannel descriptors in p2p moduleSnapshotClientinterface and implement itLightBlockRepositoryHow Has This Been Tested?
Add a couple unit-tests
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only