feat: add wait for masternode-status "ready"#659
Merged
Conversation
…onse for e2e test
lklimek
requested changes
Jul 19, 2023
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
shotonoff
commented
Jul 19, 2023
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
made modifications, please have a look at them
shotonoff
commented
Jul 19, 2023
Collaborator
Author
shotonoff
left a comment
shotonoff
left a comment
There was a problem hiding this comment.
answered to the comment
lklimek
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
In some cases Tenderdash may crash if it runs in
validatormode and it can't get pro-tx hash by some external reason.As result, Tenderdash crashes and docker supervisor runs it again until node gets pro-tx hash
What was done?
Implement wait-for logic, that checks the
masternode statusuntil getREADY. If the status isWAITING_FOR_PROTXthen waits for 1 second and retry the operation, otherwise exit.How Has This Been Tested?
The function covers with the test
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only