fix(consensus): PrepareProposal should not be called during replay#678
Merged
fix(consensus): PrepareProposal should not be called during replay#678
Conversation
shumkov
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
When replaying WAL on proposer, Tenderdash calls RequestPrepareProposal and creates new proposal, to drop it soon and use the one from replay process.
This can affect multiple mechanisms, including block locking.
What was done?
Skip creating proposal in replay mode.
How Has This Been Tested?
Unit tests, e2e tests passed
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only