-
Notifications
You must be signed in to change notification settings - Fork 19
feat(ci): add pre-commit and format code #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kevinlin09, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces pre-commit hooks to automate code formatting and linting, ensuring code consistency and quality across the project. It integrates several popular tools such as Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces pre-commit to enforce code style and quality, which is a great step. The formatting changes across the codebase improve consistency. However, the configurations for pylint and mypy are overly permissive, disabling many useful checks. I've left specific comments on how to improve this. I also found a few bugs that should be addressed.
| data["stop"] = stop | ||
| if max_tokens is not None: | ||
| data[max_tokens] = max_tokens | ||
| data[max_tokens] = max_tokens # type: ignore[index] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line appears to have a bug. The variable max_tokens is an integer, but it's being used as a dictionary key. The intention was likely to use the string 'max_tokens' as the key. The added # type: ignore[index] suppresses a type error but doesn't fix the underlying issue.
| data[max_tokens] = max_tokens # type: ignore[index] | |
| data['max_tokens'] = max_tokens # type: ignore[index] |
| super().__init__( | ||
| self, | ||
| task_id=task_id, | ||
| task_status=task_status, | ||
| results=res, | ||
| **kwargs, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a bug here. super().__init__ is called with self as the first positional argument. This will cause the dictionary to be initialized with its own items, which is likely not the intended behavior. You should remove self from the call.
super().__init__(
task_id=task_id,
task_status=task_status,
results=res,
**kwargs,
)| super().__init__( | ||
| self, | ||
| task_id=task_id, | ||
| task_status=task_status, | ||
| video_url=video_url, | ||
| **kwargs, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to another comment, there seems to be a bug here. super().__init__ is called with self as the first positional argument. This will cause the dictionary to be initialized with its own items, which is likely not the intended behavior. You should remove self from the call.
super().__init__(
task_id=task_id,
task_status=task_status,
video_url=video_url,
**kwargs,
)| --disable=C0114, # Disable missing module docstring for quick dev | ||
| --disable=C0115, # Disable missing class docstring for quick dev | ||
| --disable=C0116, # Disable missing function or method docstring for quick dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| args: [ | ||
| --ignore-missing-imports, | ||
| --disable-error-code=var-annotated, | ||
| --disable-error-code=union-attr, | ||
| --disable-error-code=assignment, | ||
| --disable-error-code=attr-defined, | ||
| --disable-error-code=import-untyped, | ||
| --disable-error-code=truthy-function, | ||
| --follow-imports=skip, | ||
| --explicit-package-bases, | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mypy configuration is very permissive, with many checks disabled. While this can be a starting point, it significantly reduces the benefits of static type checking. For example, --ignore-missing-imports can hide import errors. It would be beneficial to create a plan to gradually remove these disabled checks to improve the type safety and robustness of the codebase.
No description provided.