Resolve test_literals()
#812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahyurick
requested review from
ayushdg,
charlesbluca,
galipremsagar and
jdye64
as code owners
sarahyurick
commented
Sep 27, 2022
sarahyurick
commented
Sep 27, 2022
ayushdg
reviewed
Oct 3, 2022
Collaborator
ayushdg
left a comment
ayushdg
left a comment
There was a problem hiding this comment.
Thanks for this! Changes generally look good to me.
Could you also add an implementation for getTime32Value similar to time64 and potentially add a test case for time32 if possible
sarahyurick
commented
Oct 4, 2022
sarahyurick
commented
Oct 4, 2022
Collaborator
Author
Upon further inspection, I don't think much is needed in terms of Time32/Time64 stuff, and we can just use the existing After @andygrove 's PR (#825) is merged, I think this PR will be very small. |
andygrove
reviewed
Oct 10, 2022
sarahyurick
changed the title
test_literals()test_literals()
Co-authored-by: Andy Grove <andygrove73@gmail.com>
ayushdg
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do
SELECT TIME '08:08:00.091' AS "T", we just need to add logic forTime64. SinceTime32is also an Arrow Data Type, I added that too.