Add pre commit action #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobson
force-pushed
the
add-pre-commit-action
branch
from
39cf9ad to
a42441a
Compare
Closed
jrbourbeau
reviewed
Nov 22, 2022
.github/workflows/pre-commit.yml
Outdated
| @@ -0,0 +1,12 @@ | |||
| name: Linting | |||
|
|
|||
| on: [push] | |||
Member
There was a problem hiding this comment.
Will this still appear as a PR check? Do we need to include pull_request here?
Contributor
Author
There was a problem hiding this comment.
Oh, we might. Good catch
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
jrbourbeau
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #27 to go in first