Skip to content

Add support for cross-building for ARM#166

Merged
jacobtomlinson merged 15 commits intodask:mainfrom
holdenk:make-things-work-on-arm-for-upstream
Aug 5, 2021
Merged

Add support for cross-building for ARM#166
jacobtomlinson merged 15 commits intodask:mainfrom
holdenk:make-things-work-on-arm-for-upstream

Conversation

@holdenk
Copy link
Copy Markdown
Contributor

@holdenk holdenk commented Jul 23, 2021

I run a mixed arm & amd64 cluster so I've been using a forked version of the Dockerfiles. I figured I'd clean them up a bit and see if y'all are interested.

@jacobtomlinson
Copy link
Copy Markdown
Member

Hey @holdenk. Great to see you here!

Thanks so much for raising this. This would close #128.

Looks like CI is failing. If I remember right from the last time we tried this it's because buildkit doesn't support loading contexts with subdirectories like we do here with :base-notebook.

context: github.com/jupyter/docker-stacks.git#master:base-notebook

Do you have any thoughts on how we can work around this?

Comment thread README.md Outdated
Comment thread base/Dockerfile Outdated
@holdenk
Copy link
Copy Markdown
Contributor Author

holdenk commented Jul 23, 2021

.@jacobtomlinson I'm not super familiar with that part, normally I'd just copy the directory to make it accesiable in the build context or set up a symlink. I can take a look but it might take me a few cycles to figure out :)

Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing some changes here @holdenk.

I'm a little worried that this change means our base image will be Python 3.8 and the notebook image will be Python 3.9. We try hard to keep these environments in lock step.

See specific comments below.

Comment thread docker-compose.yml
Comment thread notebook/Dockerfile Outdated
Comment thread base/Dockerfile
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking awesome thanks @holdenk!

This seems ready, are you good for me to merge?

@holdenk
Copy link
Copy Markdown
Contributor Author

holdenk commented Aug 3, 2021

Yeah let's go ahead and merge this I've got one follow on PR that I'll raise for making this compatible with the JupyterHub launcher :)

@holdenk
Copy link
Copy Markdown
Contributor Author

holdenk commented Aug 4, 2021

Actually I think I've discovered a problem with the mamba part, give me a minute.

@holdenk
Copy link
Copy Markdown
Contributor Author

holdenk commented Aug 4, 2021

Ah yup found it, only showed up on ARM but I had a bad thing in my bash command let me just validate it.

@holdenk
Copy link
Copy Markdown
Contributor Author

holdenk commented Aug 4, 2021

Fixed it :) Launches locally on ARM as well now & loads dask.

Unrelated change we don't need this one just yet (got picked up from my branch where I'm doing the integration with jupyter launcehr)
@jacobtomlinson jacobtomlinson merged commit 68b1abf into dask:main Aug 5, 2021
@jacobtomlinson
Copy link
Copy Markdown
Member

Woo thanks @holdenk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants