Add support for cross-building for ARM#166
Conversation
… the notebook container to be compatible with the default jupyterhub
|
Hey @holdenk. Great to see you here! Thanks so much for raising this. This would close #128. Looks like CI is failing. If I remember right from the last time we tried this it's because buildkit doesn't support loading contexts with subdirectories like we do here with dask-docker/docker-compose.yml Line 25 in 5c77838 Do you have any thoughts on how we can work around this? |
|
.@jacobtomlinson I'm not super familiar with that part, normally I'd just copy the directory to make it accesiable in the build context or set up a symlink. I can take a look but it might take me a few cycles to figure out :) |
…nd target a specific version of miniforge3
…d container instead of rolling our own
jacobtomlinson
left a comment
There was a problem hiding this comment.
Thanks for pushing some changes here @holdenk.
I'm a little worried that this change means our base image will be Python 3.8 and the notebook image will be Python 3.9. We try hard to keep these environments in lock step.
See specific comments below.
… nb base image somewhere with put permissions.
jacobtomlinson
left a comment
There was a problem hiding this comment.
This is looking awesome thanks @holdenk!
This seems ready, are you good for me to merge?
|
Yeah let's go ahead and merge this I've got one follow on PR that I'll raise for making this compatible with the JupyterHub launcher :) |
|
Actually I think I've discovered a problem with the mamba part, give me a minute. |
|
Ah yup found it, only showed up on ARM but I had a bad thing in my bash command let me just validate it. |
|
Fixed it :) Launches locally on ARM as well now & loads dask. |
Unrelated change we don't need this one just yet (got picked up from my branch where I'm doing the integration with jupyter launcehr)
|
Woo thanks @holdenk! |
I run a mixed arm & amd64 cluster so I've been using a forked version of the Dockerfiles. I figured I'd clean them up a bit and see if y'all are interested.