-
-
Notifications
You must be signed in to change notification settings - Fork 37
Fix flake8 warnings #73
Conversation
|
@jbcrail do you think travis should fail if flake8 fails ? |
|
Also, Thanks! |
|
Yeah, nice. A flake8 PR == <3 :) |
|
@jbcrail are there other files you want to fix ? should we agree on some linting styles (column limits) and ignore versioneer.py ? I'm +1 on failing travis is linting fails, do you want to add that as well ? Happy to do all these thing but thought I'd ask since you are well into fixing these errors :) |
|
@quasiben I'm finished updating the files now that flake8 passes. I just noticed that you're using YAPF and certainly want to stick with the project's agreed-upon styling. I had originally set flake8 to use 119 (Django default), but I can update flake8 to use YAPF's defined column width of 120. I've already updated Travis to fail on flake8 errors/warnings. I also can update Travis to run flake8 only on the After making these changes, should I run YAPF to format the code? |
|
@jbcrail, apologies for letting this drag on. I think we should merge this and remove YAPF. Thank you so much for this contribution! |
|
merging |
No description provided.