Skip to content

Avoid KeyError on worker restart #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumeeb merged 2 commits into from
Oct 2, 2018
Merged

Avoid KeyError on worker restart #138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db175b4
Search for job_id in finished_jobs, or even create new one
guillaumeeb Aug 24, 2018
19551d1
warning about potential memory issue
guillaumeeb Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dask_jobqueue/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,16 @@ def add_worker(self, scheduler, worker=None, name=None, **kwargs):

# if this is the first worker for this job, move job to running
if job_id not in self.running_jobs:
logger.debug("this is a new job")
self.running_jobs[job_id] = self.pending_jobs.pop(job_id)
logger.debug("this is a new job or restarting worker")
if job_id in self.pending_jobs:
self.running_jobs[job_id] = self.pending_jobs.pop(job_id)
elif job_id in self.finished_jobs:
logger.warning('Worker %s restart in Job %s. '
'This can be due to memory issue.', w, job_id)
self.running_jobs[job_id] = self.finished_jobs.pop(job_id)
else:
logger.error('Unknown job_id: %s for worker %s', job_id, w)
self.running_jobs[job_id] = {}

# add worker to dict of workers in this job
self.running_jobs[job_id][w.name] = w
Expand Down