Fix container naming issue #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NAME` Done as the new name should be more accurate
jacobtomlinson
approved these changes
May 23, 2022
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Awesome thanks for tackling this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of an incorrect container name when a custom container name is specified. It does so by always using the correct name from
Pod.pod_template.spec.containers[0].name.In addition to that, it also has some minor other changes:
aarch64(Apple M1) at the momentKUBECLUSTER_WORKER_CONTAINER_NAMEtoKUBECLUSTER_CONTAINER_NAMEand changed it's value to"dask-container"to be more precise (as it might be use for both, scheduler and worker containers)Closes #466