List dependencies correctly in distributions. #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that when installing `dask-mpi` by itself, it does not come with any dependencies, contrary to what `setup.py` hints at. On a barebones cluster, I got this trying to set up a small reproducer: ``` -bash-4.2$ python3 -mvenv foobar; . ./foobar/bin/activate; pip install dask-mpi Collecting dask-mpi Using cached dask_mpi-2022.4.0-py3-none-any.whl (11 kB) Installing collected packages: dask-mpi Successfully installed dask-mpi-2022.4.0 (foobar) -bash-4.2$ pip list Package Version ---------- -------- dask-mpi 2022.4.0 pip 22.0.4 setuptools 47.1.0 ``` It seems that the code that actually specifies the dependencies has been commented out for a while. This PR reactivates it. Tested with `python -mbuild -n` (no build isolation due to the YAML dependency for `setup.py`) and looking at the `METADATA` file of the resulting wheel.
|
@kmpaul any idea why these are commented out? It looks like @andersy005 made the change some time ago. |
|
thank you for working on this fix, @matz-e
It appears that I commented out these lines as a temporary solution in this pull request, but I completely forgot to submit a follow-up pull request to address the issue I raised. |
andersy005
approved these changes
Sep 25, 2023
|
Thanks for this, @matz-e! And thank you @andersy005 for you're quick fix! Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when installing
dask-mpiby itself, it does not comewith any dependencies, contrary to what
setup.pyhints at.On a barebones cluster, I got this trying to set up a small reproducer:
It seems that the code that actually specifies the dependencies has been
commented out for a while. This PR reactivates it.
Tested with
python -mbuild -n(no build isolation due to the YAMLdependency for
setup.py) and looking at theMETADATAfile of theresulting wheel.