Skip to content

Conversation

@andersy005
Copy link
Member

@andersy005 andersy005 commented Jul 4, 2019

@kmpaul,

I wasn't sure of what to do when parsing the environment.yml when versions are specified with >= or <=. So, I commented these two lines out in def environment_dependencies function in setup.py for the time being:

if isinstance(obj, string_types):	
        dependencies.append(obj.replace('=', '=='))

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #36 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   93.93%   93.79%   -0.15%     
==========================================
  Files           4        4              
  Lines         132      129       -3     
==========================================
- Hits          124      121       -3     
  Misses          8        8
Impacted Files Coverage Δ
dask_mpi/cli.py 96.96% <ø> (-0.09%) ⬇️
dask_mpi/core.py 100% <ø> (ø) ⬆️
dask_mpi/common.py 87.71% <100%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67e3b1...7195895. Read the comment docs.

@andersy005 andersy005 requested review from kmpaul and mrocklin July 4, 2019 05:11
@andersy005 andersy005 marked this pull request as ready for review July 4, 2019 05:11
- dask
- distributed
- dask>=2.0
- distributed>=2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect both distributed and click to come by default in the dask metapackage.

@mrocklin
Copy link
Member

mrocklin commented Jul 4, 2019

This seems good to me. Thanks @andersy005 !

@kmpaul
Copy link
Collaborator

kmpaul commented Jul 4, 2019

Nice job, @andersy005! This looks good.

@kmpaul kmpaul merged commit 781229e into dask:master Jul 4, 2019
@andersy005 andersy005 deleted the sync_drop_py2 branch March 10, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uri_from_host_port moved Drop Python 2.7 tests?

3 participants