Run the tutorial on CI #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Sets nbsphinx execute to true 2. Changes solution cells to be hidden in the source, rather than `%load` magics. For now, I've skipped execution of the ML notebook. It really is written to be run on a cluster at the moment, and will need some restructructing. I'll do that in a followup.
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
TomAugspurger
commented
Dec 11, 2019
| "# Your parallel code here..." | ||
| ] | ||
| }, | ||
| { |
Member
Author
There was a problem hiding this comment.
It doesn't show up well in nbsphinx, but this cell is hidden in Jupyterlab. Not sure what it will look like in the rendered version, but it'll probably be visible, and that's probably what we want.
Reply via ReviewNB
TomAugspurger
commented
Dec 11, 2019
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": {}, |
Member
Author
There was a problem hiding this comment.
Unfortunately, I had to comment this out to avoid hanging while executing the notebook. I think that's an acceptable tradeoff.
AFAICT, nbsphinx can't skip execution of individual cells.
Reply via ReviewNB
mrocklin
approved these changes
Dec 11, 2019
| "\n", | ||
| "## Exercise: Print `Hello, world!`\n", | ||
| "Each notebook will have exercises for you to solve. You'll be given a blank or partially completed cell, followed by a \"magic\" cell that will load the solution. For example\n", | ||
| "Each notebook will have exercises for you to solve. You'll be given a blank or partially completed cell, followed by a hidden cell with a solution. For example.\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.