Skip to content

Fix handling of missing min/max parquet statistics during filtering#10042

Merged
rjzamora merged 11 commits intodask:mainfrom
rjzamora:fix-missing-stats-filtering
Mar 27, 2023
Merged

Fix handling of missing min/max parquet statistics during filtering#10042
rjzamora merged 11 commits intodask:mainfrom
rjzamora:fix-missing-stats-filtering

Conversation

@rjzamora
Copy link
Copy Markdown
Member

@rjzamora rjzamora commented Mar 9, 2023

Tweaks logic in apply_filters, and improves test coverage for filtering on columns with missing min/max statistics.

@rjzamora rjzamora added parquet bug Something is broken labels Mar 9, 2023
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjzamora
Copy link
Copy Markdown
Member Author

Note: Remaining CI failures are unrelated to these changes

@rjzamora rjzamora mentioned this pull request Mar 21, 2023
6 tasks
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to you on this one @rjzamora

@rjzamora
Copy link
Copy Markdown
Member Author

I'll plan to merge this after 2023.3.2 is released.

@rjzamora rjzamora merged commit 7c7192f into dask:main Mar 27, 2023
@rjzamora rjzamora deleted the fix-missing-stats-filtering branch March 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_parquet.py::test_select_filtered_column[fastparquet]: pandas backend fails to filter NoneType

3 participants