Install mimesis in CI environments#10105
Merged
jrbourbeau merged 2 commits intodask:mainfrom Mar 22, 2023
Merged
Conversation
jrbourbeau
reviewed
Mar 22, 2023
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @charlesbluca! This LGTM if CI is happy
jrbourbeau
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10090, we noticed that
dask/tests/test_datasets.py::test_deterministichad been failing for some time but had gone unnoticed sincemimesiswasn't being installed in our CI environments.This PR adds
mimesisto the environment files and resolves the test.pre-commit run --all-files