Skip to content

Un-xfail test_different_columns_are_allowed with pyarrow strings active#10109

Merged
jrbourbeau merged 2 commits intodask:mainfrom
j-bennet:j-bennet/test-different-columns
Mar 23, 2023
Merged

Un-xfail test_different_columns_are_allowed with pyarrow strings active#10109
jrbourbeau merged 2 commits intodask:mainfrom
j-bennet:j-bennet/test-different-columns

Conversation

@j-bennet
Copy link
Copy Markdown
Contributor

Unxfail dask/dataframe/io/tests/test_csv.py::test_different_columns_are_allowed.

Part of #10029.

  • Tests added / passed
  • Passes pre-commit run --all-files

@j-bennet j-bennet changed the title Unxfail test_different_columns_are_allowed. [pyarrow strings] Unxfail test_different_columns_are_allowed Mar 22, 2023
@j-bennet j-bennet requested a review from jrbourbeau March 22, 2023 21:02
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

EDIT: Will merge once CI is finished

@j-bennet
Copy link
Copy Markdown
Contributor Author

CI is happy, except for upstream. Failures are unrelated though - recent deprecations.

@jrbourbeau jrbourbeau changed the title [pyarrow strings] Unxfail test_different_columns_are_allowed Un-xfail test_different_columns_are_allowed with pyarrow strings active Mar 23, 2023
@jrbourbeau jrbourbeau merged commit f69261c into dask:main Mar 23, 2023
@j-bennet j-bennet deleted the j-bennet/test-different-columns branch March 23, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants