Skip to content

The axis keyword in DataFrame.rolling/Series.rolling is deprecated#10110

Merged
jrbourbeau merged 4 commits intodask:mainfrom
j-bennet:j-bennet/upstream-rolling-deprecations
Mar 23, 2023
Merged

The axis keyword in DataFrame.rolling/Series.rolling is deprecated#10110
jrbourbeau merged 4 commits intodask:mainfrom
j-bennet:j-bennet/upstream-rolling-deprecations

Conversation

@j-bennet
Copy link
Copy Markdown
Contributor

@j-bennet j-bennet commented Mar 23, 2023

Following this change in upstream:

Xref #10089.

Fixes upstream CI build failures related to the axis keyword in .rolling, such as:

dask/dataframe/io/tests/test_parquet.py::test_optimize_getitem_and_nonblockwise[2 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/io/tests/test_parquet.py::test_optimize_and_not[2 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_time_rolling_methods[48 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_methods[96 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_time_rolling_cov[4 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_time_rolling_large_window_fixed_chunks[6 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_time_rolling_large_window_variable_chunks[4 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_agg_aggregate: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_groupby_rolling: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_cov[8 failing variants]: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_raises: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_names: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_axis: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_partition_size: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_rolling_repr: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_time_rolling_repr: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
dask/dataframe/tests/test_rolling.py::test_time_rolling_constructor: FutureWarning: The 'axis' keyword in DataFrame.rolling is deprecated and will be removed in a future version. Call the method without the axis keyword instead.
  • Tests added / passed
  • Passes pre-commit run --all-files

@j-bennet
Copy link
Copy Markdown
Contributor Author

Note that upstream build still fails, but those are different failures. Unfortunately, we have quite a few deprecations that appeared in upstream lately and are not yet closed.

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-bennet

Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
@jrbourbeau jrbourbeau merged commit 1a6014c into dask:main Mar 23, 2023
@j-bennet j-bennet deleted the j-bennet/upstream-rolling-deprecations branch March 23, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants