Skip to content

GroupBy.cov raising for non-numeric grouping column#10171

Merged
jrbourbeau merged 1 commit intodask:mainfrom
phofl:cov_non_numeric_group_col
Apr 11, 2023
Merged

GroupBy.cov raising for non-numeric grouping column#10171
jrbourbeau merged 1 commit intodask:mainfrom
phofl:cov_non_numeric_group_col

Conversation

@phofl
Copy link
Copy Markdown
Collaborator

@phofl phofl commented Apr 11, 2023

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

Came across this when looking into non nano support in groupby

@jrbourbeau jrbourbeau changed the title GroupBy.cov raising for non numeric grouping column GroupBy.cov raising for non-numeric grouping column Apr 11, 2023
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @phofl -- this is in

@jrbourbeau jrbourbeau merged commit fdd9fe4 into dask:main Apr 11, 2023
@phofl phofl deleted the cov_non_numeric_group_col branch April 11, 2023 18:30
j-bennet pushed a commit to j-bennet/dask that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants