Adjust empty Index from fastparquet to object dtype#10179
Merged
jrbourbeau merged 3 commits intodask:mainfrom Apr 15, 2023
Merged
Adjust empty Index from fastparquet to object dtype#10179jrbourbeau merged 3 commits intodask:mainfrom
Index from fastparquet to object dtype#10179jrbourbeau merged 3 commits intodask:mainfrom
Conversation
phofl
changed the title
jrbourbeau
reviewed
Apr 12, 2023
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @phofl
cc @martindurant for visibility
Comment on lines
+1119
to
+1122
| if ( | ||
| parse_version(fastparquet.__version__) <= parse_version("2023.02.0") | ||
| and df.columns.empty | ||
| ): |
Member
There was a problem hiding this comment.
Is a pandas version check needed here too?
Collaborator
Author
There was a problem hiding this comment.
Added one, not strictly necessary but clearer
jrbourbeau
changed the title
Index from fastparquet to object dtype
jrbourbeau
approved these changes
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filescc @jrbourbeau
As expected, fix was relatively easy. I opened dask/fastparquet#859 to fix in fastparquet