Update dataframe.convert_string to dataframe.convert-string#10191
Merged
jrbourbeau merged 1 commit intodask:mainfrom Apr 14, 2023
Merged
Update dataframe.convert_string to dataframe.convert-string#10191jrbourbeau merged 1 commit intodask:mainfrom
dataframe.convert_string to dataframe.convert-string#10191jrbourbeau merged 1 commit intodask:mainfrom
Conversation
j-bennet
changed the title
convert_string -> convert-string, for consistencyconvert_string -> convert-string
github-actions
bot
added
dataframe
documentation
phofl
approved these changes
Apr 14, 2023
jrbourbeau
approved these changes
Apr 14, 2023
| import dask | ||
|
|
||
| if dask.config.get("dataframe.convert_string"): | ||
| if bool(dask.config.get("dataframe.convert-string")): |
Member
There was a problem hiding this comment.
IIUC this should already be a bool, so I don't think the bool call here is necessary. It's also not incorrect, just wanted to point this out
jrbourbeau
changed the title
convert_string -> convert-stringdataframe.convert_string to dataframe.convert-string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic change, just to be consistent with the rest of the config settings.
pre-commit run --all-files