Merged
Conversation
jrbourbeau
reviewed
Jul 3, 2023
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @phofl!
I take it the segfault we were working around no longer occurs?
Collaborator
Author
|
I've never heard of it, so I think it predates my pandas involvement (1.1). I can't go back further than 1.3.4 on my Mac, since we didn't provide wheels for arm back then |
jrbourbeau
approved these changes
Jul 3, 2023
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Just looked at this workaround was added 6 years ago (xref #2835). CI is passing (including our mindeps build) so I'm fine saying this isn't needed anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files