Skip to content

Unskip and adjust tests for groupby-aggregate with median using dask-expr #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crusaderky merged 1 commit into from
Jan 23, 2024
Merged

Unskip and adjust tests for groupby-aggregate with median using dask-expr #10832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions dask/dataframe/tests/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,8 +1090,6 @@ def test_groupby_normalize_by():

def test_aggregate__single_element_groups(agg_func):
spec = agg_func
if DASK_EXPR_ENABLED and spec == "median":
pytest.xfail("not yet implemented")

# nunique/cov is not supported in specs
if spec in ("nunique", "cov", "corr"):
Expand Down Expand Up @@ -1323,7 +1321,6 @@ def test_shuffle_aggregate_defaults(shuffle_method):
assert any("shuffle" in l for l in dsk.layers)


@pytest.mark.xfail(DASK_EXPR_ENABLED, reason="median not yet supported")
@pytest.mark.parametrize("spec", [{"c": "median"}, {"b": "median", "c": "max"}])
@pytest.mark.parametrize("keys", ["a", ["a", "d"]])
def test_aggregate_median(spec, keys, shuffle_method):
Expand All @@ -1341,10 +1338,11 @@ def test_aggregate_median(spec, keys, shuffle_method):
expected = pdf.groupby(keys).aggregate(spec)
assert_eq(actual, expected)

with pytest.raises(ValueError, match="must use shuffl"):
ddf.groupby(keys).aggregate(spec, shuffle_method=False)
with pytest.raises(ValueError, match="must use shuffl"):
ddf.groupby(keys).median(shuffle_method=False)
if not DASK_EXPR_ENABLED:
with pytest.raises(ValueError, match="must use shuffl"):
ddf.groupby(keys).aggregate(spec, shuffle_method=False).compute()
with pytest.raises(ValueError, match="must use shuffl"):
ddf.groupby(keys).median(shuffle_method=False).compute()


@pytest.mark.skipif(DASK_EXPR_ENABLED, reason="deprecated in pandas")
Expand Down