Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 20m 34s ⏱️ + 3m 25s For more details on these failures, see this check. Results for commit 22564aa. ± Comparison against base commit 0ad38fc. |
milesgranger
approved these changes
Feb 16, 2024
Contributor
milesgranger
left a comment
milesgranger
left a comment
There was a problem hiding this comment.
LGTM, thanks @crusaderky.
CI failure seems unrelated:
FAILED dask/dataframe/tests/test_dataframe.py::test_ffill - ValueError: All NaN partition encountered in
fillna. Try usingdf.repartitionto increase the partition size, or specifylimitinfillna.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align parsing of the variable to the config schema, which states it must be strictly True or False. This looks like leftover code from a moment where it could be None?