Skip to content

Test vs. intermediate versions of numpy and pandas#12372

Merged
crusaderky merged 1 commit into
dask:mainfrom
crusaderky:pandas-23
May 12, 2026
Merged

Test vs. intermediate versions of numpy and pandas#12372
crusaderky merged 1 commit into
dask:mainfrom
crusaderky:pandas-23

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented May 6, 2026 •
edited
Loading

Closes #12371

Change CI matrix to

numpy

  • numpy=1.24 (mindeps-array, mindeps-dataframe, mindeps-optional)
  • numpy=1.24 (3.10)
  • numpy=2.0 (3.11)
  • numpy=2.2 (3.12)
  • numpy>=2.4 (3.13, 3.14)

pandas

  • pandas=2.0 (mindeps-dataframe, mindeps-optional)
  • pandas=2.1 (3.10)
  • pandas=2.2 (3.11)
  • pandas=2.3 (3.12)
  • pandas>=3.0 (3.13, 3.14)

pyarrow

  • pyarrow=16 (mindeps-dataframe, mindeps-optional)
  • pyarrow=16 (3.10)
  • pyarrow=19 (3.11)
  • pyarrow=22 (3.12)
  • pyarrow>=24 (3.13, 3.14)

Note: the 3.10 environment is astonishingly slow to resolve. I tried tampering with it and the result was conda hanging very badly.

@crusaderky crusaderky changed the title Test vs. pandas=2.3 Test vs. pandas 2.2 and 2.3 May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     20 files  ±0       20 suites  ±0   4h 55m 56s ⏱️ + 3m 2s
 18 295 tests ±0   17 011 ✅ ±  0   1 272 💤 ±  0  12 ❌ ±0 
299 528 runs  ±0  257 509 ✅ +192  42 007 💤  - 192  12 ❌ ±0 

For more details on these failures, see this check.

Results for commit a3a03f1. ± Comparison against base commit 4a34ce8.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky force-pushed the pandas-23 branch 2 times, most recently from 90260e0 to c07fe73 Compare May 6, 2026 17:31
@crusaderky crusaderky changed the title Test vs. pandas 2.2 and 2.3 Test vs. intermediate versions of numpy and pandas May 6, 2026
crusaderky
crusaderky commented May 6, 2026
View reviewed changes
Comment thread dask/dataframe/dask_expr/_groupby.py

def groupby_get_group(df, *by_key, get_key=None, columns=None):
if PANDAS_GE_300 and is_scalar(get_key):
if PANDAS_GE_220 and is_scalar(get_key):
Copy link
Copy Markdown
Collaborator Author

@crusaderky crusaderky May 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrbourbeau what is Dask's policy in regards to this?

In pandas 2.2 and 2.3, a scalar get_key issues a warning and in 3.0 it stops working.
In Dask, as of main, it will keep working forever, with a warning on 2.2 and 2.3 an no warning starting from 3.0.
This PR would suppress the warning on 2.2 and 2.3.

@crusaderky crusaderky marked this pull request as ready for review May 7, 2026 09:47
@crusaderky crusaderky force-pushed the pandas-23 branch 2 times, most recently from a93e78e to 1a67f6d Compare May 7, 2026 12:00
@crusaderky crusaderky marked this pull request as draft May 8, 2026 17:21
@crusaderky crusaderky marked this pull request as ready for review May 12, 2026 19:58
@crusaderky crusaderky merged commit b40345d into dask:main May 12, 2026
25 of 26 checks passed
@crusaderky crusaderky deleted the pandas-23 branch May 12, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unfiltered warnings with pandas=2.3

1 participant

@crusaderky