Support futures in from_delayed#1961
Merged
mrocklin merged 7 commits intodask:masterfrom Feb 12, 2017
Merged
Conversation
mrocklin
force-pushed
the
from-delayed-futures
branch
from
14fc657 to
b16c2e2
Compare
Member
Author
|
cc @jcrist can I get a quick yes/no on if you agree with this change? |
jcrist
reviewed
Feb 6, 2017
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
Overall this seems fine to me.
| from dask.delayed import Delayed | ||
| from dask.delayed import Delayed, delayed | ||
| if not isinstance(value, Delayed) and hasattr(value, 'key'): | ||
| value = delayed(value) |
Member
There was a problem hiding this comment.
Why the check for 'key' here but not elsewhere (I assume this is to duck-type on futures)?
Member
Author
There was a problem hiding this comment.
I've now added the check for key elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit wonky in that I had to compute before calling assert_eq.
Still this is a common tripping point.
cc @jcrist for review