API: Ensure set_index always sorts the index#2290
Merged
mrocklin merged 4 commits intodask:masterfrom May 3, 2017
Merged
Conversation
TomAugspurger
commented
May 3, 2017
| result = dd.concat([ddf, ddf.rename(columns={"B": "C"})], axis=1) | ||
| expected = pd.concat([pdf, pdf.rename(columns={"B": "C"})], axis=1) | ||
| assert_eq(result, expected) | ||
| assert not result.compute().index.is_monotonic # didn't accidentally sort |
Member
Author
There was a problem hiding this comment.
This is an unrelated test that I had to fix. It's now out of date, since set_index will sort.
Member
|
+1 from me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are edge cases (like the test case here) where we find that things are sorted between partitions, but don't check that they are sorted within partitions.
This fixes the problem by just calling
sort_indexon each partition. There's might be a more elegant / efficient solution where we can avoid callingsort_indexin some cases, but I haven't been able to find it yet.Closes #2288