Rename bag.concat to bag.flatten#2402
Merged
mrocklin merged 2 commits intodask:masterfrom Jun 2, 2017
Merged
Conversation
Concat is the name we use from toolz. However flatten may be more clear. Additionally db.concat does something totally different.
jcrist
reviewed
Jun 1, 2017
dask/bag/core.py
Outdated
| for i in range(self.npartitions)) | ||
| return type(self)(merge(self.dask, dsk), name, self.npartitions) | ||
|
|
||
| concat = flatten |
Member
There was a problem hiding this comment.
Should probably deprecate the old name.
| b = db.from_sequence([1, 2, 3]).map(lambda x: x * [1, 2, 3]) | ||
| assert list(b.concat()) == [1, 2, 3] * sum([1, 2, 3]) | ||
|
|
||
| def test_flatten(): |
Member
There was a problem hiding this comment.
Any reason to keep the above concat tests around?
Member
Author
There was a problem hiding this comment.
Yes, that concat operates entirely differently and remains valid.
Member
Author
|
Merging soon if no further comments |
mauhai
added a commit
to mauhai/dask
that referenced
this pull request
Oct 11, 2017
i am updating the docs according to dask#2402
3 tasks
jcrist
pushed a commit
that referenced
this pull request
Oct 11, 2017
i am updating the docs according to #2402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concat is the name we use from toolz. However flatten may be more clear.
Additionally db.concat does something totally different.