Merged
Conversation
Closed
jakirkham
reviewed
Sep 8, 2017
| if append: | ||
| pf = fastparquet.api.ParquetFile(path, open_with=myopen, sep=sep) | ||
| if pf.file_scheme != 'hive': | ||
| if pf.file_scheme not in ['hive', 'empty', 'flat']: |
Member
There was a problem hiding this comment.
Is there a "flat" scheme somewhere? Am only finding "empty" and "simple". Is it suppose to be "simple"?
Member
Author
There was a problem hiding this comment.
"flat" is new, when there are multiple files, but all are in one directory
Member
|
The change seems clean and fine to me from a general perspective, but admittedly I don't know lots about parquet. Trusting your judgement and merging. |
Member
|
Just realized I forgot we merge squash. Would it make sense to just make this the default (or only) kind of merge in the repo settings? |
Member
Author
|
There was only one commit, squash would not have made a difference |
Member
|
I usually squash merge by default. I very rarely rebase-merge if the
commit history is particularly clean/concise/valuable.
…On Fri, Sep 8, 2017 at 1:18 PM, Martin Durant ***@***.***> wrote:
There was only one commit, squash would not have made a difference
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2667 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszCjaWLV1_x6xt8EnRwotFxZdekrEks5sgXbzgaJpZM4PRY-5>
.
|
Member
|
Just switched off merge-commits for this repo so this can't happen again. |
Member
|
Great! Thanks so much @jcrist. Sorry for the trouble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.