Merged
Conversation
Closed
Member
|
Looks perfect to me |
Member
|
Thanks @jakirkham. |
Member
Author
|
Thanks guys. |
fujiisoup
pushed a commit
to fujiisoup/dask
that referenced
this pull request
Feb 3, 2018
* Add ptp Implements `ptp` for Dask Arrays. Basically just the difference between the `max` and `min` with an optional `axis` argument. Skipped providing `out` even though NumPy provides it. Not sure that it makes much sense to have `out` for Dask Arrays or that it is of any value. * Export ptp in Dask Array's public API * Document ptp in Dask Array API docs * Test ptp Provide some test cases for the Dask Array `ptp` implementation with different `axis` arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2687
Adds a Dask Array implementation of
ptp. Simply takes the difference between themaxand theminof the Dask Array. Also supports an optionalaxisargument. In the default case acts on the flattened array. Documents the function and provides some tests to make sure it behaves ok. Skips implementing theoutargument as it's unclear what value this provides for Dask Arrays.