Merged
Conversation
Implements the equivalent of NumPy's `allclose` for Dask Arrays. Does this by simply using the existing `isclose` operation for comparing each element. Then calls `all` on the result of `isclose` to collapse it down to a single `bool`.
Provides a very simple test of Dask Array's `allclose`, which compares the result against NumPy's `allclose`. Basically borrows and tweaks a test used for Dask Array's `isclose`.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2756
Implements the equivalent of NumPy's
allclosefor Dask Arrays and adds it to the public API. Simply leverages Dask Array'sisclosefunction andallmethod for the computation. Provides a simple test of Dask Array'sallclosecompared to NumPy. Includesallclosein Dask Array's API docs and mentions it in the changelog.