Close resource profiler process on __exit__#2871
Merged
jcrist merged 1 commit intodask:masterfrom Nov 8, 2017
Merged
Conversation
Previously ``ResourceProfiler`` would start a tracker process on `__init__`, which would then persist until `.close()` was called (or the profiler was garbage collected). This led to processes unintentionally persisting longer than intended by users. Now we close the tracker process on context exit, and restart it if it's closed on enter. When registered globally (not in a context manager) the process persists until `close` is explictly called, as it was before. All user code should continue to work the same, and the cost of restarting the process should be minimal compared to the cost of the computations being profiled.
Member
Author
|
Ping @pitrou for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
ResourceProfilerwould start a tracker process on__init__, which would then persist until.close()was called (or theprofiler was garbage collected). This led to processes unintentionally
persisting longer than intended by users.
Now we close the tracker process on context exit, and restart it if it's
closed on enter. When registered globally (not in a context manager) the
process persists until
closeis explictly called, as it was before.All user code should continue to work the same, and the cost of
restarting the process should be minimal compared to the cost of the
computations being profiled.
Fixes #2869.