Change numpy versioning in make_sliced_dtype#3187
Merged
mrocklin merged 2 commits intodask:masterfrom Feb 21, 2018
Merged
Conversation
It looks like numpy reverted a change in how it handles struct dtypes. This also simplifies a test to only test against numpy behavior, rather than explicitly test different outcomes for different versions.
mrocklin
force-pushed
the
numpy-1.14.1-compa
branch
from
95d7555 to
7eee6c7
Compare
mrocklin
force-pushed
the
numpy-1.14.1-compa
branch
from
7eee6c7 to
d9b17a5
Compare
Member
Author
|
Merging this soon if there are no further comments. This is breaking current tests on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like numpy reverted a change in how it handles struct dtypes.
This also simplifies a test to only test against numpy behavior,
rather than explicitly test different outcomes for different versions.
flake8 daskdocs/source/changelog.rstfor all changesand one of the
docs/source/*-api.rstfiles for new API