Skip to content

Add Python 3.7 to travis.yml#3894

Merged
mrocklin merged 2 commits intodask:masterfrom
mrocklin:python-3.7
Aug 22, 2018
Merged

Add Python 3.7 to travis.yml#3894
mrocklin merged 2 commits intodask:masterfrom
mrocklin:python-3.7

Conversation

@mrocklin
Copy link
Copy Markdown
Member

  • Tests added / passed
  • Passes flake8 dask

@mrocklin
Copy link
Copy Markdown
Member Author

@TomAugspurger what is the right behavior for this:

  /home/travis/build/dask/dask/dask/dataframe/methods.py:333: FutureWarning: Sorting because non-concatenation axis is not aligned. A future version
  of pandas will change to not sort by default.
  
  To accept the future behavior, pass 'sort=False'.
  
  To retain the current behavior and silence the warning, pass 'sort=True'.
  
    out = pd.concat(dfs3, join=join)

@TomAugspurger
Copy link
Copy Markdown
Member

For end-users doing something like

a = pd.DataFrame(columns=['a', 'b'])
b = pd.DataFrame(columns=['b', 'a'])
dd.concat([a, b])

we want that warning to come through, to match pandas.

Internal to dask.dataframe, we should ensure that we either have aligned columns, or specify sort if we rely on the output order. I can try to fix all these warnings this afternoon.

- *test_and_lint
- *no_coverage
- *no_optimize
- *no_imports
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone mind me dropping this CI entry as we add one for 3.7? cc @jakirkham @jcrist

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do. We generally try to support both Python 2/3 in our codebase as there are inevitably scientific libraries that we want to pull in that haven't made the switch. Though I think this has gotten better in the past year or two, it's still a surprisingly common problem (even with new codes).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still another 2.7 entry. We used to have two. You might want to check the full file in this branch

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham does your concern still hold, given that there is another Python 2.7 entry?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Sorry. Missed the other one. This is fine.

@mrocklin
Copy link
Copy Markdown
Member Author

OK, merging this in.

@mrocklin mrocklin merged commit f644e7f into dask:master Aug 22, 2018
@mrocklin mrocklin deleted the python-3.7 branch August 22, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants