Avoid asarray and lock arguments for from_array(getitem)#4044
Merged
jakirkham merged 2 commits intodask:masterfrom Oct 3, 2018
Merged
Avoid asarray and lock arguments for from_array(getitem)#4044jakirkham merged 2 commits intodask:masterfrom
jakirkham merged 2 commits intodask:masterfrom
Conversation
Member
Author
|
Merging tomorrow if there are no further comments |
jcrist
reviewed
Oct 2, 2018
dask/array/core.py
Outdated
| slices = slices_from_chunks(chunks) | ||
|
|
||
| if not asarray or lock: | ||
| if getitem != operator.getitem and (not asarray or lock): |
Member
There was a problem hiding this comment.
nit: should probably be is not. Not a big deal though.
Member
|
Thanks @mrocklin :) |
|
Thanks (very late!) 💐 I'm possibly not getting notifies for some reason ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4043
flake8 dask