Docs: Update futures.rst [skip ci]#4262
Merged
mrocklin merged 4 commits intodask:masterfrom Dec 5, 2018
Merged
Conversation
This PR updates `futures.rst` with some punctuation and typo corrections. However, I've found a couple of issues that may need some special oversight. Two important notes: - In the **Actors** section, some note commands were either not properly defined or were hidden on purpose, but I couldn't tell which one was it. If it was the later, then I need to revert the changes I made in order to hide the note messages. - The last two sentences in the **Asynchronous Operation** subsection of the **Actors** section require a re-write (I've highlighted them using ** **). I'm not sure if they are supposed to be a single sentence or not, but it seems like someone forgot about them when refactoring them. Someone should take a look at them to infer their real meaning.
mrocklin
reviewed
Dec 1, 2018
mrocklin
reviewed
Dec 1, 2018
docs/source/futures.rst
Outdated
|
|
||
| Usually Dask computations are composed of tasks that build off of each other in | ||
| a pure functional way. They're centrally manathat are managed by the central | ||
| a pure functional way. **They're centrally manathat are managed by the central |
Member
There was a problem hiding this comment.
This seems like a typo in the original?
Member
There was a problem hiding this comment.
Ah, right. I see that you mentioned this in the original comment. I recommend that we remove these two paragraph snippets entirely.
Member
Author
There was a problem hiding this comment.
If it doesn't add any useful information then it's best to remove them. I'll do it right away.
Improve sentence Co-Authored-By: farrajota <farrajota@users.noreply.github.com>
This commit reverts ".)" to ")."
Member
Author
|
Reverted the use of ending dots with parenthesis like in #4263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
futures.rstwith some punctuation and typo corrections. However, I've found a couple of issues that may need some special oversight.Two important notes: