rearrange_by_column: ensure that shuffle arg defaults to 'disk' if it…#4414
Merged
mrocklin merged 1 commit intodask:masterfrom Jan 23, 2019
gsakkis:master
Merged
rearrange_by_column: ensure that shuffle arg defaults to 'disk' if it…#4414mrocklin merged 1 commit intodask:masterfrom gsakkis:master
mrocklin merged 1 commit intodask:masterfrom
gsakkis:master
Conversation
…'s None in dask.config
Member
|
Thanks @gsakkis ! Should we add a test for this as well? I'm fine either way. Either this PR or dask/distributed#2475 should probably have the test that you provided in the issue. |
Contributor
Author
|
I think the test should be on distributed as this is where it manifests. Can you point me in which test file it should go? Btw as I commented something is wrong or missing in my dev environment when running |
Member
|
This is in. Thanks @gsakkis ! |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
…'s None in dask.config (dask#4414)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complementary fix for dask/distributed#2473