Avoid groupby.agg(callable) in groupby-var#4482
Merged
mrocklin merged 1 commit intodask:masterfrom Feb 14, 2019
Merged
Conversation
Member
Author
|
@jangorecki this may affect your benchmarks |
This has two benefits
1. It's much faster the following benchmark shows a 5x improvement
2. It doesn't require the pandas-like container to implement
groupby.agg(callable), which helps cudf
Benchmark
---------
I get five-ish seconds for this on master
And less than one second on this branch
```
from time import time
import dask
df = dask.datasets.timeseries(dtypes={'id': int, 'data': float}).persist()
start = time()
for i in range(3):
df.groupby('id').data.std().compute()
stop = time()
print(stop - start)`
```
27e911c to
095793f
Compare
TomAugspurger
approved these changes
Feb 14, 2019
Contributor
|
Nice! |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
This has two benefits
1. It's much faster the following benchmark shows a 5x improvement
2. It doesn't require the pandas-like container to implement
groupby.agg(callable), which helps cudf
Benchmark
---------
I get five-ish seconds for this on master
And less than one second on this branch
```
from time import time
import dask
df = dask.datasets.timeseries(dtypes={'id': int, 'data': float}).persist()
start = time()
for i in range(3):
df.groupby('id').data.std().compute()
stop = time()
print(stop - start)`
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two benefits
groupby.agg(callable), which helps cudf
Benchmark
I get five-ish seconds for this on master
And less than one second on this branch
flake8 daskcc @thomcom @TomAugspurger