Skip to content

Remove additional pandas warnings in tests#4576

Merged
jrbourbeau merged 4 commits intodask:masterfrom
mrocklin:pandas-warnings
Mar 17, 2019
Merged

Remove additional pandas warnings in tests#4576
jrbourbeau merged 4 commits intodask:masterfrom
mrocklin:pandas-warnings

Conversation

@mrocklin
Copy link
Copy Markdown
Member

  • Tests added / passed
  • Passes flake8 dask

@mrocklin
Copy link
Copy Markdown
Member Author

Merging shortly if there are no further comments

@jrbourbeau
Copy link
Copy Markdown
Member

Do we want to deprecate clip_lower and clip_upper in Dask? I'm not sure what's been done in these situations in the past

@mrocklin
Copy link
Copy Markdown
Member Author

mrocklin commented Mar 17, 2019 via email

@mrocklin
Copy link
Copy Markdown
Member Author

Yeah, we just call map_partitions(M.clip_upper, ...) so we'll end up calling this function on the meta object, which will trigger the warning from Pandas

@mrocklin
Copy link
Copy Markdown
Member Author

OK to merge @jrbourbeau ?

@jrbourbeau
Copy link
Copy Markdown
Member

Yeah, this LGTM

@jrbourbeau jrbourbeau merged commit aea27d1 into dask:master Mar 17, 2019
@mrocklin mrocklin deleted the pandas-warnings branch March 17, 2019 22:46
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019
* Remove additional pandas warnings in tests

* support older pandas versions

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants