Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional pandas warnings in tests #4576

Merged
merged 4 commits into from Mar 17, 2019
Merged

Conversation

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 10, 2019

  • Tests added / passed
  • Passes flake8 dask
@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Mar 17, 2019

Merging shortly if there are no further comments

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Mar 17, 2019

Do we want to deprecate clip_lower and clip_upper in Dask? I'm not sure what's been done in these situations in the past

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Mar 17, 2019

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Mar 17, 2019

Yeah, we just call map_partitions(M.clip_upper, ...) so we'll end up calling this function on the meta object, which will trigger the warning from Pandas

@mrocklin
Copy link
Member Author

@mrocklin mrocklin commented Mar 17, 2019

OK to merge @jrbourbeau ?

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Mar 17, 2019

Yeah, this LGTM

@jrbourbeau jrbourbeau merged commit aea27d1 into dask:master Mar 17, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin mrocklin deleted the pandas-warnings branch Mar 17, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* Remove additional pandas warnings in tests

* support older pandas versions

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants