Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional pandas warnings in tests #4576

Merged
merged 4 commits into from Mar 17, 2019

Conversation

Projects
None yet
2 participants
@mrocklin
Copy link
Member

commented Mar 10, 2019

  • Tests added / passed
  • Passes flake8 dask
@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

Merging shortly if there are no further comments

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Do we want to deprecate clip_lower and clip_upper in Dask? I'm not sure what's been done in these situations in the past

@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

Yeah, we just call map_partitions(M.clip_upper, ...) so we'll end up calling this function on the meta object, which will trigger the warning from Pandas

@mrocklin

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

OK to merge @jrbourbeau ?

@jrbourbeau

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Yeah, this LGTM

@jrbourbeau jrbourbeau merged commit aea27d1 into dask:master Mar 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mrocklin mrocklin deleted the mrocklin:pandas-warnings branch Mar 17, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Remove additional pandas warnings in tests (dask#4576)
* Remove additional pandas warnings in tests

* support older pandas versions

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.