Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison against pd.Series #4613

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@amerkel2
Copy link
Contributor

commented Mar 19, 2019

fixes #4596

  • Tests added / passed
  • Passes flake8 dask
@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

We switched to using is_series_like in order to support objects that looked like Pandas objects, but were not like cudf or, in some future, arrow.

@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

The underlying issue may be resolved in #4533

@amerkel2

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

No, even with #4533 merged the test added in this PR fails. The comment two lines above my change suggests that in this place, a different code path shall be taken for dask Series than for pandas series and similar. But is_series_like evaluates to True both for dask and pandas series, so it doesn't seem suitable here.

Show resolved Hide resolved dask/dataframe/core.py Outdated
Handle dask series corretly.
Co-Authored-By: amerkel2 <andreas.merkel@blue-yonder.com>

@mrocklin mrocklin merged commit 24bbcdb into dask:master Mar 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Thanks @amerkel2 . This is in!

Also, I notice that this is your first code contribution to this repository. Welcome!

@amerkel2

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Thank you, it's a pleasure!

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.