Fix comparison against pd.Series#4613
Merged
mrocklin merged 2 commits intodask:masterfrom Mar 20, 2019
Merged
Conversation
Member
|
We switched to using |
Member
|
The underlying issue may be resolved in #4533 |
Contributor
Author
|
No, even with #4533 merged the test added in this PR fails. The comment two lines above my change suggests that in this place, a different code path shall be taken for dask Series than for pandas series and similar. But |
mrocklin
reviewed
Mar 19, 2019
Co-Authored-By: amerkel2 <andreas.merkel@blue-yonder.com>
Member
|
Thanks @amerkel2 . This is in! Also, I notice that this is your first code contribution to this repository. Welcome! |
Contributor
Author
|
Thank you, it's a pleasure! |
jorge-pessoa
pushed a commit
to jorge-pessoa/dask
that referenced
this pull request
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4596
flake8 dask