Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison against pd.Series #4613

Merged
merged 2 commits into from Mar 20, 2019
Merged

Conversation

@amerkel2
Copy link
Contributor

@amerkel2 amerkel2 commented Mar 19, 2019

fixes #4596

  • Tests added / passed
  • Passes flake8 dask
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 19, 2019

We switched to using is_series_like in order to support objects that looked like Pandas objects, but were not like cudf or, in some future, arrow.

@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 19, 2019

The underlying issue may be resolved in #4533

@amerkel2
Copy link
Contributor Author

@amerkel2 amerkel2 commented Mar 19, 2019

No, even with #4533 merged the test added in this PR fails. The comment two lines above my change suggests that in this place, a different code path shall be taken for dask Series than for pandas series and similar. But is_series_like evaluates to True both for dask and pandas series, so it doesn't seem suitable here.

dask/dataframe/core.py Outdated Show resolved Hide resolved
Co-Authored-By: amerkel2 <andreas.merkel@blue-yonder.com>
@mrocklin mrocklin merged commit 24bbcdb into dask:master Mar 20, 2019
2 checks passed
@mrocklin
Copy link
Member

@mrocklin mrocklin commented Mar 20, 2019

Thanks @amerkel2 . This is in!

Also, I notice that this is your first code contribution to this repository. Welcome!

@amerkel2
Copy link
Contributor Author

@amerkel2 amerkel2 commented Mar 21, 2019

Thank you, it's a pleasure!

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants