Specify fork-based contributions #4619
Conversation
| clone the fork:: | ||
|
|
||
| git clone git@github.com:dask/dask.git | ||
| git clone https://github.com/<your-github-username>/dask |
There was a problem hiding this comment.
I would actually recommend to clone the main repo and add your fork as an additional remote. Otherwise you won't get updates from master in your clone.
There was a problem hiding this comment.
Thanks for the review @xhochy, that's a good point. However since we don't go into much detail about git workflows here, and instead link to the pandas contributing guide which recommends cloning the fork and adding the main repo as an upstream remote, I have a slight preference for staying with cloning the fork. I think this consistency could help contributors who are new to git or GitHub.
There was a problem hiding this comment.
Agreed. I personally add the main branch as upstream, and keep origin as my fork. Updating from master is then just git pull upstream master.
|
Thanks @jrbourbeau, merging. |
* Specify fork based contributions [skip ci] * Update introductory label to good first issue [skip ci]
3 participants
This PR updates the development docs to specify contributions should use fork-based pull requests. Also updates "introductory" label to "good first issue" label.