Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify fork-based contributions #4619

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@jrbourbeau
Copy link
Member

commented Mar 21, 2019

This PR updates the development docs to specify contributions should use fork-based pull requests. Also updates "introductory" label to "good first issue" label.


git clone git@github.com:dask/dask.git
git clone https://github.com/<your-github-username>/dask

This comment has been minimized.

Copy link
@xhochy

xhochy Mar 21, 2019

Contributor

I would actually recommend to clone the main repo and add your fork as an additional remote. Otherwise you won't get updates from master in your clone.

This comment has been minimized.

Copy link
@jrbourbeau

jrbourbeau Mar 21, 2019

Author Member

Thanks for the review @xhochy, that's a good point. However since we don't go into much detail about git workflows here, and instead link to the pandas contributing guide which recommends cloning the fork and adding the main repo as an upstream remote, I have a slight preference for staying with cloning the fork. I think this consistency could help contributors who are new to git or GitHub.

This comment has been minimized.

Copy link
@jcrist

jcrist Mar 21, 2019

Member

Agreed. I personally add the main branch as upstream, and keep origin as my fork. Updating from master is then just git pull upstream master.

@jcrist

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Thanks @jrbourbeau, merging.

@jcrist jcrist merged commit 243339a into dask:master Mar 21, 2019

@jrbourbeau jrbourbeau deleted the jrbourbeau:update-contributing branch Mar 21, 2019

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

Specify fork-based contributions (dask#4619)
* Specify fork based contributions [skip ci]

* Update introductory label to good first issue [skip ci]

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Specify fork-based contributions (dask#4619)
* Specify fork based contributions [skip ci]

* Update introductory label to good first issue [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.