Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify fork-based contributions #4619

Merged
merged 2 commits into from Mar 21, 2019
Merged

Conversation

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Mar 21, 2019

This PR updates the development docs to specify contributions should use fork-based pull requests. Also updates "introductory" label to "good first issue" label.


git clone git@github.com:dask/dask.git
git clone https://github.com/<your-github-username>/dask
Copy link
Contributor

@xhochy xhochy Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually recommend to clone the main repo and add your fork as an additional remote. Otherwise you won't get updates from master in your clone.

Loading

Copy link
Member Author

@jrbourbeau jrbourbeau Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @xhochy, that's a good point. However since we don't go into much detail about git workflows here, and instead link to the pandas contributing guide which recommends cloning the fork and adding the main repo as an upstream remote, I have a slight preference for staying with cloning the fork. I think this consistency could help contributors who are new to git or GitHub.

Loading

Copy link
Member

@jcrist jcrist Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I personally add the main branch as upstream, and keep origin as my fork. Updating from master is then just git pull upstream master.

Loading

@jcrist
Copy link
Member

@jcrist jcrist commented Mar 21, 2019

Thanks @jrbourbeau, merging.

Loading

@jcrist jcrist merged commit 243339a into dask:master Mar 21, 2019
@jrbourbeau jrbourbeau deleted the update-contributing branch Mar 21, 2019
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this issue May 14, 2019
* Specify fork based contributions [skip ci]

* Update introductory label to good first issue [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants