Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_count parameter to groupby sum method #4648

Merged
merged 4 commits into from Mar 30, 2019

Conversation

Projects
None yet
2 participants
@henriqueribeiro
Copy link
Contributor

commented Mar 29, 2019

  • Tests added / passed
  • Passes flake8 dask

As requested in #4586 here is the implementation of min_counts for groupby sum method

@mrocklin

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

Thanks @henriqueribeiro . Looks good to me. Merging in 24 hours if there are no further comments.

@mrocklin mrocklin merged commit a008ab5 into dask:master Mar 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

asmith26 added a commit to asmith26/dask that referenced this pull request Apr 22, 2019

Add min_count parameter to groupby sum method (dask#4648)
* add min_count parameter to sum method on groupby
* add prod method also

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Add min_count parameter to groupby sum method (dask#4648)
* add min_count parameter to sum method on groupby
* add prod method also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.