Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify regions kwarg to array.store #4759

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@martindurant
Copy link
Member

commented Apr 30, 2019

Fixes #4393

  • Tests added / passed
  • Passes flake8 dask
@martindurant

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

(sorry, should have skipped tests)

@jakirkham , would you say this clarifies the docstring sufficiently?

@jakirkham

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

LGTM. @rainwoodman, could you please take a look?

@jcrist

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Thanks @martindurant, merging.

@jcrist jcrist merged commit fc95fe0 into dask:master Apr 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martindurant martindurant deleted the martindurant:array_store_doc branch Apr 30, 2019

jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019

Thomas-Z added a commit to Thomas-Z/dask that referenced this pull request May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.