Skip to content

Clarify regions kwarg to array.store#4759

Merged
jcrist merged 1 commit intodask:masterfrom
martindurant:array_store_doc
Apr 30, 2019
Merged

Clarify regions kwarg to array.store#4759
jcrist merged 1 commit intodask:masterfrom
martindurant:array_store_doc

Conversation

@martindurant
Copy link
Copy Markdown
Member

Fixes #4393

  • Tests added / passed
  • Passes flake8 dask

@martindurant
Copy link
Copy Markdown
Member Author

(sorry, should have skipped tests)

@jakirkham , would you say this clarifies the docstring sufficiently?

@jakirkham
Copy link
Copy Markdown
Member

LGTM. @rainwoodman, could you please take a look?

@jcrist
Copy link
Copy Markdown
Member

jcrist commented Apr 30, 2019

Thanks @martindurant, merging.

@jcrist jcrist merged commit fc95fe0 into dask:master Apr 30, 2019
@martindurant martindurant deleted the array_store_doc branch April 30, 2019 22:37
jorge-pessoa pushed a commit to jorge-pessoa/dask that referenced this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

da.store is confused when regions is a tuple of tuple of slices.

3 participants