Fix undefined meta for str.split(expand=False)#5022
Merged
TomAugspurger merged 1 commit intodask:masterfrom Jun 28, 2019
Merged
Fix undefined meta for str.split(expand=False)#5022TomAugspurger merged 1 commit intodask:masterfrom
meta for str.split(expand=False)#5022TomAugspurger merged 1 commit intodask:masterfrom
Conversation
TomAugspurger
approved these changes
Jun 28, 2019
Member
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
Strange that flake8 doesn't catch this. Thanks!
Member
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
Actually, one small request to preserve the name.
dask/dataframe/accessor.py
Outdated
| meta = type(self._series._meta)([" ".join(["a"] * 2 * n)]) | ||
| meta = meta.str.split(n=n, expand=expand, pat=pat) | ||
| else: | ||
| meta = list |
Member
There was a problem hiding this comment.
Ah, actually, can you try meta = (self._series.name, list) here? Will that work?
Right now we're dropping Series.name, if it has one.
Contributor
Author
There was a problem hiding this comment.
list didn't work but object did 👍
|
|
||
|
|
||
| def test_str_noexpand(): | ||
| s = pd.Series(["a b c d", "aa bb cc dd", "aaa bbb ccc dddd"]) |
Member
There was a problem hiding this comment.
Can you add name='foo' here too? Ensure that it stays.
TomAugspurger
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this got broken in #4744.