Avoid unnecessary step in pivot_table#5173
Merged
jcrist merged 1 commit intodask:masterfrom Jul 30, 2019
dsaxton:pivot-mod
Merged
Avoid unnecessary step in pivot_table#5173jcrist merged 1 commit intodask:masterfrom dsaxton:pivot-mod
jcrist merged 1 commit intodask:masterfrom
dsaxton:pivot-mod
Conversation
Member
|
Just to be clear, we weren't doing the actual calculation unnecessarily. We just built the task graph unnecessarily. The changes here seem fine though, if ever so slightly harder to follow. Will merge tomorrow if there aren't any objections. |
dsaxton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black dask/flake8 daskThis PR is to avoid doing unnecessary calculation in
dataframe.reshape.pivot_tablewhen theaggfuncis either"sum"or"count". Right now both aggregations (sums and counts) are calculated regardless of theaggfunc, even though we only need both whenaggfunc == "mean".