Avoid NumPy scalar string representation in tokenize#5527
Merged
jrbourbeau merged 3 commits intodask:masterfrom Oct 23, 2019
Merged
Avoid NumPy scalar string representation in tokenize#5527jrbourbeau merged 3 commits intodask:masterfrom
jrbourbeau merged 3 commits intodask:masterfrom
Conversation
Member
|
This makes sense to me. Didn't know numpy supported redefining printers. |
TomAugspurger
approved these changes
Oct 23, 2019
Member
Author
|
Thanks for reviewing @jcrist @TomAugspurger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates how
tokenizeoperates on NumPy scalars to avoid using array string representations.Since NumPy allows users to customize how arrays are printed, the current
tokenizebehavior can lead to non-deterministic hashes for NumPy scalars in some edge cases. Instead, here we usex.item()to convert NumPy scalars to Python scalars which are then used intokenize. This allows us to cover edge cases wherestr(x)has been modified without a performance degradation. With the changes in this PR we have:and on the current
masterbranch:cc @jcrist if you get a moment to take a look at this or have any thoughts on the topic
black dask/flake8 dask