Add transparent compression for on-disk shuffle with partd#5786
Merged
TomAugspurger merged 11 commits intodask:masterfrom Jan 16, 2020
Merged
Add transparent compression for on-disk shuffle with partd#5786TomAugspurger merged 11 commits intodask:masterfrom
TomAugspurger merged 11 commits intodask:masterfrom
Conversation
Member
|
Thanks for submitting a PR for #5704 . The default config file can be found here: https://github.com/dask/dask/blob/master/dask/dask.yaml . Can I ask that you also add to the config test here: dask/dask/tests/test_config.py Lines 417 to 418 in 5db6dad |
Member
|
What do we think about the name? Two things come to mind:
|
Contributor
Author
Member
|
I'd suggest |
Member
TomAugspurger
left a comment
There was a problem hiding this comment.
Thanks for the PR. Can you also add tests?
Member
|
There's a linting issue too: https://travis-ci.org/dask/dask/jobs/637027038#L1437-L1440. Contributing guidelines are at https://docs.dask.org/en/latest/develop.html#code-formatting. You might want to install and use pre-commit. |
…+ Refactored naming of tests + Refactor to fix an incompatibility between black and flake8 style enforcement on multi-line strings and line length which lead CI to fail
Co-Authored-By: Tom Augspurger <TomAugspurger@users.noreply.github.com>
TomAugspurger
approved these changes
Jan 16, 2020
Member
|
Thanks @ChrWesp! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shoud close #5704
This change adds transparent file compression for on-disk shuffle via partd.
The compression algorithm can be specified by dask config (keyword shuffle_disk_compression).
It can be any algorithm which is exposed by partd.compressed. In case an algorithm is absent, it silently falls back to no compression.
Please check one thing - I am not sure about the naming schema and where to document the config parameter.
black dask/flake8 dask