Add DataFrame and Series memory_usage_per_partition methods#5971
Merged
TomAugspurger merged 3 commits intodask:masterfrom Mar 4, 2020
Merged
Add DataFrame and Series memory_usage_per_partition methods#5971TomAugspurger merged 3 commits intodask:masterfrom
TomAugspurger merged 3 commits intodask:masterfrom
Conversation
Member
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
Thanks @jrbourbeau. I see that total_mem_usage is also used in test_repartition_partition_size in test_dataframe.py, and I think it's being called with deep=False now. I think we do want deep=True there, since we do have a string column.
LGTM otherwise.
Member
Author
|
Ah good catch, thanks @TomAugspurger! |
TomAugspurger
approved these changes
Mar 3, 2020
Member
Author
|
The Python 3.7 failure is unrelated and appears to sporadically pop up in |
Member
|
Seems like a flaky test with distributed. Opened #5972 for that and restarted the build. |
Member
|
Thanks @jrbourbeau! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
memory_usage_per_partitionmethod to Dask'sSeriesandDataFramecollections. Closes #5952cc @xhochy @quasiben
black dask/flake8 dask